Skip to content

Fix: gradle secrets enforcement breaking tests#43

Merged
dkhawk merged 7 commits into
mainfrom
fix/gradle-secrets-enforcement-breaking-tests
May 27, 2026
Merged

Fix: gradle secrets enforcement breaking tests#43
dkhawk merged 7 commits into
mainfrom
fix/gradle-secrets-enforcement-breaking-tests

Conversation

@dkhawk

@dkhawk dkhawk commented May 20, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes the CI failures where unit tests were crashing due to missing API keys.

Key changes:

  • Defined 'isCI' flag in the root build.gradle.kts.
  • Bypassed API key check in Maps3DJavaApplication when in CI or unit test mode.
  • Provided default manifest placeholders for API keys when in CI mode.

Centralize the secrets.properties enforcement logic into a single
authoritative check in the root build.gradle.kts file, removing
heavy duplication across six subprojects.

Replace brittle runtime environment checks with safe, build-time
BuildConfig.IS_CI constants for automated testing pipelines.

- Create root build.gradle.kts for workspace-wide validation
- Remove duplicated secrets-checking blocks from subproject scripts
- Inject BuildConfig.IS_CI and apply manifest placeholders in CI
- Update Application classes to respect BuildConfig.IS_CI early returns
- Untrack LOG.md and add to local exclude file
- Fill out missing PLACES_API_KEY in defaults properties
@dkhawk dkhawk requested a review from kikoso May 27, 2026 19:11

@kikoso kikoso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkhawk dkhawk merged commit c93a790 into main May 27, 2026
6 checks passed
@dkhawk dkhawk deleted the fix/gradle-secrets-enforcement-breaking-tests branch May 27, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants